Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for scripts like train_hypergrid with replay_buffer > 0 #167

Open
saleml opened this issue Feb 27, 2024 · 0 comments
Open

Add tests for scripts like train_hypergrid with replay_buffer > 0 #167

saleml opened this issue Feb 27, 2024 · 0 comments
Assignees
@josephdviviano
Labels
high priority Let's do these first!
Milestone
V2

Comments

@saleml
Copy link
Collaborator

saleml commented Feb 27, 2024

A recent PR introduced a bug where train_hypergrid doesn't converge if replay_buffer is set to 100.

This should be caught with the tests !
@josephdviviano josephdviviano added this to the V2 milestone Apr 16, 2024
@josephdviviano josephdviviano self-assigned this Jun 12, 2024
@josephdviviano josephdviviano added the high priority Let's do these first! label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephdviviano josephdviviano

Labels
high priority Let's do these first!
Projects
None yet
Milestone
V2
Development

No branches or pull requests
2 participants
@josephdviviano @saleml