Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Change -- Always Recalculate Everything #179

Open
josephdviviano opened this issue Apr 16, 2024 · 0 comments
Open

API Change -- Always Recalculate Everything #179

josephdviviano opened this issue Apr 16, 2024 · 0 comments
Assignees
@josephdviviano @saleml
Labels
enhancement New feature or request high priority Let's do these first!
Milestone
V2

Comments

@josephdviviano
Copy link
Collaborator

  • Right now, to do on-policy, or off policy, or "true" off policy sampling efficiently, you need to set "recalculate" flags appropriately.
  • If you do this incorrectly, you end up with bugs.
  • We propose to change things such that everything is reclaulated by default. Therefore the user always gets the expected output, and will only need to learn the API to speed up their code.
  • This will need to be accompanied by documentation.
@josephdviviano josephdviviano added the enhancement New feature or request label Apr 16, 2024
@josephdviviano josephdviviano added this to the V2 milestone Apr 16, 2024
@josephdviviano josephdviviano added the high priority Let's do these first! label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephdviviano josephdviviano

@saleml saleml

Labels
enhancement New feature or request high priority Let's do these first!
Projects
None yet
Milestone
V2
Development

No branches or pull requests
2 participants
@josephdviviano @saleml