You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After reviewing the codes, I brought two possible refactoring ideas.
Move the parameter preprocessor in GFNModule to Sampler. This could separate env from GFNModule (since the preprocessor is defined in env) and pass the preprocessed states to the GFNModule. One drawback is that the input of GFNModule would not be State anymore.
There are two preprocessor files: src/gfn/preprocessors.py and src/gfn/gym/helpers/preprocessors.py. If this is not intended, it would be better to merge them into one file.
These are naive suggestions, so please feel free to comment, and let's discuss!
The text was updated successfully, but these errors were encountered:
For 1 - I'm not sure where the states would be passed? I think we could also explore integrating the sampler completely within the GFNModule although I'm worried this might be a footgun down the line if some method requires that modularity. @saleml thoughts?
I don't love src/gfn/gym/helpers in general. I feel like the "helpers" should either be integrated into the main library or the individual gym files, and the whole folder should be removed.
After reviewing the codes, I brought two possible refactoring ideas.
Move the parameter
preprocessor
inGFNModule
toSampler.
This could separateenv
fromGFNModule
(since thepreprocessor
is defined inenv
) and pass the preprocessed states to theGFNModule.
One drawback is that the input ofGFNModule
would not beState
anymore.There are two preprocessor files:
src/gfn/preprocessors.py
andsrc/gfn/gym/helpers/preprocessors.py.
If this is not intended, it would be better to merge them into one file.These are naive suggestions, so please feel free to comment, and let's discuss!
The text was updated successfully, but these errors were encountered: