Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing semantics of "get_terminating_state_indices" and "get_state_indices" in discrete EBM #219

Open
josephdviviano opened this issue Nov 15, 2024 · 0 comments
Open

Confusing semantics of "get_terminating_state_indices" and "get_state_indices" in discrete EBM #219

josephdviviano opened this issue Nov 15, 2024 · 0 comments
Assignees
@josephdviviano @saleml
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@josephdviviano
Copy link
Collaborator

@saleml - I was wondering if you could better document the logic here:

torchgfn/src/gfn/gym/discrete_ebm.py

Line 209 in b5d909e

def get_states_indices(self, states: DiscreteStates) -> torch.Tensor:

I am not clear why these two cases are different and I think others will have a similar question.
@josephdviviano josephdviviano added documentation Improvements or additions to documentation question Further information is requested labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephdviviano josephdviviano

@saleml saleml

Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephdviviano @saleml