Why is baseURL unset in getResourceByUrl?

[nitwhiz]

getResourceByUrl requests without the base-url set in the client used for this request. Why is it designed this way?

pokenode-ts/src/clients/utility.client.ts

Lines 50 to 54 in 6572881

	return new Promise<T>((resolve, reject) => {
	this.api
	.get(url, { baseURL: "" })
	.then((response: AxiosResponse<T>) => resolve(response.data))
	.catch((error: AxiosError<string>) => reject(error));

This makes it hard to use this client with a selfhosted instance of the PokeAPI JSON-files, where following the urls in the responses is necessary.

[Gabb-c]

Hey @nitwhiz, I appreciate your input and apologize for the delayed response.

Initially, the decision to remove the baseURL from this method was made with the intention of facilitating the retrieval of resources from sources other than the default one.

It may be advantageous to consider the inclusion of an optional parameter that allows for the overriding of the baseURL, if necessary.

[nitwhiz]

an optional parameter sounds good.