Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGSM isn't in according to POSIX ACL standard #3861

Open
LeChatP opened this issue May 15, 2022 · 3 comments · May be fixed by #3880
Open

LGSM isn't in according to POSIX ACL standard #3861

LeChatP opened this issue May 15, 2022 · 3 comments · May be fixed by #3880

Comments

@LeChatP
Copy link

LeChatP commented May 15, 2022

LinuxGSM/lgsm/functions/check_permissions.sh

Lines 11 to 26 in d86a709

if [ -f "${rootdir}/${selfname}" ]; then
if [ "$(find "${rootdir}/${selfname}" -not -user "$(whoami)" | wc -l)" -ne "0" ]; then
selfownissue=1
fi
fi
if [ -d "${functionsdir}" ]; then
if [ "$(find "${functionsdir}" -not -user "$(whoami)" | wc -l)" -ne "0" ]; then
funcownissue=1
fi
fi
if [ -d "${serverfiles}" ]; then
if [ "$(find "${serverfiles}" -not -user "$(whoami)" | wc -l)" -ne "0" ]; then
filesownissue=1
fi
fi
if [ "${selfownissue}" == "1" ]||[ "${funcownissue}" == "1" ]||[ "${filesownissue}" == "1" ]; then

Hello, I use my rust servers with full acl and these rules aren't in according to POSIX ACL standard.

As example, in a Apache server, the right way to manage FTP (according to POSIX ACL standard) is to create one user per real person and give setgid bit to shared folder. Then users can upload in this directory with shared group ownership but user ownership is set as uploader. So you can give access to Linux users to upload and www-data keep the rights to read/write by group access. https://www.gnu.org/software/coreutils/manual/html_node/Directory-Setuid-and-Setgid.html

But these rules are blocking the server because my users are legitimatly uploading in lgsm server directory. Nothing about any root issue that is explained in FAQ.
@LeChatP LeChatP changed the title LGSM aren't in according to POSIX ACL standard LGSM isn't in according to POSIX ACL standard May 15, 2022
@h3o66
Copy link
Member

h3o66 commented May 23, 2022

Maybe we consider to add a variable to skip the check.
We should probably note them somewhere that is not safe by default.

@h3o66 h3o66 linked a pull request May 30, 2022 that will close this issue
Draft
13 tasks
@h3o66 h3o66 linked a pull request May 30, 2022 that will close this issue
feat: allow to disable the permission check #3880
Draft
13 tasks
@h3o66
Copy link
Member

h3o66 commented May 30, 2022

Created a draft PR that could allow to skip this check.
Imho this should be only documented and not included into the default config, as i would say that if this is enabled we do not give support if this does not work.

@dgibbs64
Copy link
Member

dgibbs64 commented Oct 8, 2023

I think the way forward with permissions will be to only check that the group has correct permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow to disable the permission check h3o66/LinuxGSM
3 participants
@dgibbs64 @h3o66 @LeChatP