Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change namespace Exception name. #39

Open
quentin389 opened this issue Aug 26, 2013 · 1 comment
Open

Change namespace Exception name. #39

quentin389 opened this issue Aug 26, 2013 · 1 comment
Assignees

Comments

@quentin389
Copy link
Collaborator

I don't wanna know who wrote that code:

use \Exception as BaseException;
class Exception extends BaseException
{}

but that's some really terrible piece of code.

I'm gonna change the in-namespace exception to something like BrowscapException, and update all the throws.
That can break someones code, but tbh it's a fair price for not keeping this monster alive.

@ghost ghost assigned quentin389 Aug 26, 2013
@ntvsx193
Copy link

ntvsx193 commented Sep 8, 2013

Pull request #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants