Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset the timezone #65

Open
xrstf opened this issue May 20, 2014 · 0 comments
Open

Do not reset the timezone #65

xrstf opened this issue May 20, 2014 · 0 comments

Comments

@xrstf
Copy link

xrstf commented May 20, 2014

I was pretty surprised to find that when I instantiate Browscap, my timezone suddenly changed. It's correct that you need a timezone to be set, but doing it in the constructor (or anywhere in the library for that matter) is a bad approach.

Instead, you should rely on my app or the testing bootstrap code to handle dates and timezones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant