Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LISA cluster labels in the tutorial vignette #40

Open
jponmattam opened this issue Mar 31, 2023 · 1 comment
Open

LISA cluster labels in the tutorial vignette #40

jponmattam opened this issue Mar 31, 2023 · 1 comment

Comments

@jponmattam
Copy link

https://github.com/GeoDaCenter/rgeoda/blob/master/vignettes/rgeoda_tutorial.Rmd

I think lines 284 and 285 should be switched in the Vignette. When you run lisa_labels(lisa) in line 291-292, the order is "Low-High", "High-Low" <-- since everything else is the same order as lines 291 - 287, the 3 and 4 category labels seem like they should be switched - ie. 3 = "Low-High" and 4 = "High-Low"

@bpfree
Copy link

bpfree commented Jun 7, 2023

@lixun910, I would be curious about this as well as the comment seems correct. On the tutorial page online it states that high-low is 3 and low-high is 4. Yet when printing the labels, 3 is low-high and 4 is high-low (4th and 5th elements, respectively).

Screenshot 2023-06-07 at 13 50 24

When I also produce it on my end, 3 would be low-high while 4 would high-low:

Screenshot 2023-06-07 at 13 50 53

I had assumed that this was corrected from #18, but maybe we are mistaken. As can see, using 0.0.10-2 is producing those labels.

sessionInfo()
R version 4.2.0 (2022-04-22)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS 13.4

Matrix products: default
LAPACK: /Library/Frameworks/R.framework/Versions/4.2/Resources/lib/libRlapack.dylib

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
 [1] tidyr_1.3.0         terra_1.7-31        sf_1.0-13           rnaturalearth_0.3.3 rmapshaper_0.5.0    rgeos_0.6-3        
 [7] rgeoda_0.0.10-2     digest_0.6.31       rgdal_1.6-7         plyr_1.8.8          pdftools_3.3.3      ncf_1.3-2          
[13] janitor_2.2.0       ggplot2_3.4.2       fs_1.6.2            fasterize_1.0.4     elsa_1.1-28         raster_3.6-20      
[19] sp_1.6-1            dplyr_1.1.2         pacman_0.5.1       

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.10        lubridate_1.9.2    lattice_0.21-8     class_7.3-22       utf8_1.2.3         V8_4.3.0          
 [7] R6_2.5.1           e1071_1.7-13       httr_1.4.6         pillar_1.9.0       rlang_1.1.1        curl_5.0.0        
[13] rstudioapi_0.14    qpdf_1.3.2         stringr_1.5.0      munsell_0.5.0      proxy_0.4-27       compiler_4.2.0    
[19] pkgconfig_2.0.3    askpass_1.1        tidyselect_1.2.0   tibble_3.2.1       codetools_0.2-19   fansi_1.0.4       
[25] withr_2.5.0        grid_4.2.0         jsonlite_1.8.4     gtable_0.3.3       lifecycle_1.0.3    DBI_1.1.3         
[31] magrittr_2.0.3     units_0.8-2        scales_1.2.1       KernSmooth_2.23-20 cli_3.6.1          stringi_1.7.12    
[37] snakecase_0.11.0   generics_0.1.3     vctrs_0.6.2        tools_4.2.0        glue_1.6.2         purrr_1.0.1       
[43] pkgload_1.3.2      timechange_0.2.0   colorspace_2.1-0   classInt_0.4-9 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants