Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change logic of attestation issuance, to handle fees #167

Open
7 tasks
divine-comedian opened this issue Sep 5, 2024 · 5 comments
Open
7 tasks

change logic of attestation issuance, to handle fees #167

divine-comedian opened this issue Sep 5, 2024 · 5 comments
Assignees
Labels
SC Integration Integration of DeVouch Smart Contract features

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Sep 5, 2024

We added a resolver contract to enforce an exact amount of ETH to be sent with each attestation using our schema. This will affect users vouching flagging and editing their attestations (deleting/revoking remains unchanged, no fee).

AC

  • can successfully vouch to a project
  • can sucessfully flag a project
  • can successfully edit attestation made to project
  • can successfully revoke/delete attestation
  • fee of 0.0001 ETH is taken on vouch/flag/edit transactions (in addition to regular gas fee)
  • no fee is taken on revoke/delete attestation
  • new attestations for vouch/flag/edit shows on relevant project and user attestation history tables
@divine-comedian
Copy link
Contributor Author

divine-comedian commented Nov 20, 2024

We've changed the approach of this feature now instead we deploy a resolver contract that will collect a specified fee for each attestation made using our schema.

if a user makes multiple attestations the fee also multiplies.

Here is a deployment on Sepolia we can start using right away:

https://sepolia.easscan.org/schema/view/0x87607c7f565dfc1473309a45e7f7d26f0915615258fffd6745fc6238822c108b

for each attestation it is expecting the user to send 0.0001 ETH

You can see some sample data in the tests I ran in foundry here: https://github.com/Giveth/DeVouch-contracts/blob/master/test/testDeployedResolver.t%20copy.sol#L40-L53

To-do

@divine-comedian divine-comedian changed the title change logic of attestation issuance, to handle new contract change logic of attestation issuance, to handle fees Nov 20, 2024
@divine-comedian
Copy link
Contributor Author

divine-comedian commented Nov 26, 2024

for merging to production"

  • - deploy resolver to op mainnet
  • - create new schema
  • - add schema to backend config and FE environment variables
  • - test with foundry script to see if it shows up
  • add note in documentation about fees

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Nov 26, 2024

@mateodaza @MohammadPCh

Test Update

  • Can successfully vouch to a project - Pass
  • Can successfully flag a project - "Pass"
  • Can successfully edit attestation made to project - "Pending"
  • Vouch details reflects on Project card - Fail
  • Vouch details reflects on Project details page - Fail
  • Vouch details reflects on "My Attestation" page - Fail
  • Flag details reflects on Project card - Fail
  • Flag details reflects on Project details page - Fail
  • Flag details reflects on "My Attestation" page - Fail
  • Can successfully revoke/delete attestation - Pending
  • Fee of 0.0001 ETH is taken on vouch/flag/edit transactions (in addition to regular gas fee) - "Pending"
  • No fee is taken on revoke/delete attestation - "Pending"
  • New attestations for vouch/flag/edit shows on relevant project and user attestation history tables - "Fail"

After successfully vouching and flagging a project, there is no record of the details on Project card, Project details page as well as my Attestation page

rii

Vouching for a Project

sep

image

Flagging a Project

image

image

@divine-comedian
Copy link
Contributor Author

My first question is WHO IS HAJIA!??? 🤭

@LatifatAbdullahi
Copy link

@divine-comedian 🤣🤣🤣🤣

Ohhh my comments while attesting.... "Hajia" is my pet name at home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SC Integration Integration of DeVouch Smart Contract features
Projects
Status: Todo
Development

No branches or pull requests

4 participants