-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Minecraft commands #13
Comments
Here is a list of Glowkit commands: https://github.com/GlowstoneMC/Glowkit/tree/master/src/main/java/org/bukkit/command/defaults I don't think they have added anything. |
There's also two in the implementation, /color and /tellraw: https://github.com/deathcap/GlowstonePlusPlus/tree/master/src/main/java/net/glowstone/command |
Oh yes, I missed those, sorry. But still, nothing from 1.8 from what I can tell. |
AFAIK commands shouldn't be in Glowstone. |
I have figured out the difference. You put commands that extend VanillaCommand in Glowkit and commands that extend BukkitCommand in Glowstone. |
Every command that isn't on a vanilla server is a BukkitCommand. |
/tellraw is probably in Glowstone because at the time it was added there wasn't any way of implementing it in Glowkit. I'm not sure about /title, might be the same reason. Edit: For /tellraw see here |
Yeah, I guess we should port them at some point. |
Yeah, it seems like Bukkit/Bukkit#1111 seems to be the way to go for tellraw. |
There is a better/newer implementation in SpongeAPI, that you can use here as well. |
Alright, thanks! |
md-5's BaseComponent seems like the thing we should be using for supporting all of this JSON text stuff. |
@deathcap you should uncheck /playsound it has a major update in 1.9 |
@GreenBeard This is a ticket about 1.8, though. Speaking of which, has there been any more movement on this? |
What version of minecraft should the behavior for the remaining commands match? |
Glowstone targets the latest Minecraft version, so 1.12 |
Though, this issue is better: #499 |
Cool, thanks. |
Is there a specific reason why this issue is still open? |
I was just about to close it in favour of #499 tbh |
Bukkit added server commands up to 1.7, but Spigot's Bukkit update for 1.8 removed all commands from the API because they instead pass through to the official Minecraft server. Glowstone can't do this obviously, so it relies on the commands in the API project, but they aren't updated for any new 1.8 features. Glowkit may have already added some; need to check. Full command list:
http://minecraft.gamepedia.com/Commands
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: