Player entities floating above ground when using Mineflayer emulator

[phylib]

Title: Player entities floating above ground when using Mineflayer emulator

Glowstone build: 2018.9.0 Release, exact commit c6e1ed01

An emulated player using the mineflayer emulator can't move because it is floating above the ground. To reproduce the issue, try using the example script from the navigate plugin.

When looking to the code, it appears that the PlayerUpdateMessage received from mineflayer contains the correct position (especially is on ground), but Glowstone does not apply this position because it assumes it as invalid in PlayerUpdateHandler line 50.

When removing the if/else construct, mineflayer works perfectly fine. I would propose to adapt the if-clause in line 46. I would do it if nobody can see problems, but I don't know the exact reason for the if/else construct. The commit message only says: "First test for this".

I would love to fix this if someone gives me the OK for adapting the if clause.

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[cedws]

If you have a fix then you should submit a PR 👍 we can always discuss the changes once they're submitted.

[Pr0methean]

This sounds like an anti-cheat feature that should only be disabled if the admin wants.