Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Social and web links do not work. #103

Closed
vldkhh opened this issue Jan 12, 2024 · 9 comments
Closed

[BUG] Social and web links do not work. #103

vldkhh opened this issue Jan 12, 2024 · 9 comments
Assignees
Labels
P2 - Medium Issues that should be addressed but are not urgent.

Comments

@vldkhh
Copy link

vldkhh commented Jan 12, 2024

Should only display if there’s a value, and open a new tab / page when clicked launching the appropriate asset.

image

@patpedrosa
Copy link

This could be happening because we didn't provide the values when the pool was created. Either way, the contract address for this pool (last icon) should show and open on celoscan.

@decentralauren
Copy link

decentralauren commented Jan 12, 2024

@krisbitney content for other values (besides the contract address) can be found here. .

@decentralauren decentralauren added the P2 - Medium Issues that should be addressed but are not urgent. label Jan 12, 2024
@krisbitney krisbitney self-assigned this Jan 13, 2024
@vldkhh
Copy link
Author

vldkhh commented Jan 24, 2024

@krisbitney @decentralauren we should add socials to verify it

@vldkhh
Copy link
Author

vldkhh commented Jan 24, 2024

@L03TJ3

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jan 29, 2024

@krisbitney
on ViewCollective page I think it should use:

export function useSubgraphCollective(id: string): SubgraphCollective | undefined {

above query includes the socials, the other doesnt

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jan 29, 2024

@decentralauren for Silvi's collective all socials are already set correctly.

@sirpy if a collective is created, is it still possible to update the socials after?

@krisbitney
Copy link
Collaborator

This is fixed in #121

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jan 29, 2024

@vldkhh this is being released to dev as we speak

@L03TJ3
Copy link
Collaborator

L03TJ3 commented Jan 30, 2024

Confirmed in call yesterday so closing

@L03TJ3 L03TJ3 closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 - Medium Issues that should be addressed but are not urgent.
Projects
None yet
Development

No branches or pull requests

5 participants