Skip to content
This repository has been archived by the owner on Jul 25, 2024. It is now read-only.

accept enter key in repo prompt in configure_delivery.sh #701

Closed
rogerthatdev opened this issue Nov 4, 2022 · 0 comments · Fixed by #702 · May be fixed by #732
Closed

accept enter key in repo prompt in configure_delivery.sh #701

rogerthatdev opened this issue Nov 4, 2022 · 0 comments · Fixed by #702 · May be fixed by #732
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rogerthatdev
Copy link
Contributor

Problem

The prompt that asks to verify the github repository does not accept the enter key, unlike the prompt for approver email.

Steps to Reproduce

Steps to reproduce the behavior:

  1. run setup.sh
  2. at the step to connect repo, enter repo owner and then repo name.
  3. When prompted to verify the repository URL, press enter instead of 'y' key
  4. it will ask that you re-enter repo owner and repo name.

Expected behavior

Would like this prompt to default to Y

Additional context

Prompt that asks for approver email accepts enter key
@rogerthatdev rogerthatdev added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Nov 4, 2022
rogerthatdev added a commit that referenced this issue Nov 4, 2022
@rogerthatdev
feature: adjust prompts in configure_delivery.sh
086b84b 
This PR will update `configure_delivery.sh`:
- Prompt to press any key to continue will accept any key - previously only accepted Enter
- Prompt to verify repository URL will accept Enter key and variations of 'yes' ('y', 'Y', 'yes', 'YES') - previously only accepted 'y'

Fixes #701
@rogerthatdev rogerthatdev mentioned this issue Nov 4, 2022
Merged
rogerthatdev added a commit that referenced this issue Dec 8, 2022
@rogerthatdev
feature: adjust prompts in configure_delivery.sh (#702)
eee313f 
This PR will update `configure_delivery.sh`:
- Prompt to press any key to continue will accept any key - previously only accepted Enter
- Prompt to verify repository URL will accept Enter key and variations of 'yes' ('y', 'Y', 'yes', 'YES') - previously only accepted 'y'

Fixes #701
@github-actions github-actions bot mentioned this issue Jan 26, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
1 participant
@rogerthatdev