Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dense predefined formats #37

Merged
merged 3 commits into from
Sep 13, 2023
Merged

add dense predefined formats #37

merged 3 commits into from
Sep 13, 2023

Conversation

willow-ahrens
Copy link
Collaborator

@willow-ahrens willow-ahrens commented Sep 11, 2023 •
edited
Loading

As suggested in the meeting today, here are the predefined formats for dense vectors and matrices

@github-actions
Copy link

github-actions bot commented Sep 11, 2023 •
edited
Loading

Automated Review URLs

BenBrock
BenBrock approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@BenBrock BenBrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Personally I like to write values[i + j * number_of_rows] to keep the order consistent but that's a very small nitpick.

@willow-ahrens willow-ahrens merged commit cd02796 into main Sep 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenBrock BenBrock BenBrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willow-ahrens @BenBrock