Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection direction difference #2041

Open
runxel opened this issue Oct 16, 2024 · 2 comments · May be fixed by #2124
Open

Selection direction difference #2041

runxel opened this issue Oct 16, 2024 · 2 comments · May be fixed by #2124
Labels
Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend

Comments

@runxel
Copy link

runxel commented Oct 16, 2024 •
edited
Loading

The selection direction should make a difference.
Usually in apps like these if you start a selection frame by dragging the mouse to the right it should only select objects that are fully inside of the selection frame. If the user drags to the left everything that is touched by the selection frame should be selected.
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Oct 16, 2024
@Keavon
Copy link
Member

Keavon commented Oct 16, 2024

I've always disliked that UX choice in the applications that do that, but it would probably make sense to have an [Inclusive / Exclusive / By Drag Direction] choice in the application's preferences because it's intuitive for some people and we'd like to support those users.

@Keavon Keavon added Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend labels Oct 16, 2024
@Keavon Keavon moved this from Short-Term to Medium-Term in Task Board Oct 16, 2024
@Keavon Keavon moved this from Medium-Term to Longer-Term in Task Board Oct 16, 2024
@pratikagr
Copy link
Contributor

Hello, I have created a PR for Left based section for now. Can you please review it?

@pratikagr pratikagr linked a pull request Dec 2, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature or request Good First Issue Good for newcomers Rust Involves Rust programming for the backend
Projects
Task Board
Status: Longer-Term
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implemented left selection logic pratikagr/Graphite
4 participants
@runxel @Keavon @pratikagr and others