Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic monitor node insertion #2044

Open
adamgerhant opened this issue Oct 16, 2024 · 0 comments
Open

Automatic monitor node insertion #2044

adamgerhant opened this issue Oct 16, 2024 · 0 comments
Labels
Graphene Involves the node graph system/engine used by Graphite

Comments

@adamgerhant
Copy link
Collaborator

adamgerhant commented Oct 16, 2024

In order to display thumbnails for every wire, a Monitor node should be placed at outputs during compilation. The number of monitor nodes should be minimized to avoid redundant clones as data flows through the graph. The outputs would be selected based on which thumbnails should be rendered, both in the node graph UI and layer panel. This would also improve #2028 and getting artboard translations in the Clear Artboards PR.

Monitor nodes will be the standard way of getting data from the node graph, as opposed to the render output. This is because the render output does not include all data in the node graph due to destructive operations like rasterize or boolean operations. We currently work around this by redundantly storing the upstream graphic group for vector data created by a boolean operation, but this is not ideal. (This is something that is still currently being discussed)

https://discord.com/channels/731730685944922173/731738914812854303/1291860544604602439
https://discord.com/channels/731730685944922173/731738914812854303/1291830448195899527

@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Oct 16, 2024
@adamgerhant adamgerhant added the Graphene Involves the node graph system/engine used by Graphite label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphene Involves the node graph system/engine used by Graphite
Projects
Status: Short-Term
Development

No branches or pull requests

2 participants
@adamgerhant and others