Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Contribution]: Implement Data Source Registration per ADR-0006 #348

Open
2 tasks done
bderusha opened this issue May 5, 2023 · 10 comments · May be fixed by #366
Open
2 tasks done

[Feature Contribution]: Implement Data Source Registration per ADR-0006 #348

bderusha opened this issue May 5, 2023 · 10 comments · May be fixed by #366
Assignees
Labels

Comments

@bderusha
Copy link
Contributor

bderusha commented May 5, 2023

What happened?

When ADR-0006 is implemented:

  • Developers can declare only the data sources they need for their project in the .csproj file
  • New data sources can be added to this project without requiring additional plumbing

Note
This feature is related to proposed ADR-0014 which expands on this to extend support to external packages.

If ADR-0014 is approved before ADR-0006 is implemented, it may be worth bundling them together.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Feature Commitment

  • I commit to contributing this feature as a PR and working with the GSF to merge this feature into the Carbon Aware SDK.
@Willmish
Copy link
Collaborator

Willmish commented May 23, 2023

Note during meeting #355 : Open for discussion on implementation details, either as a guideline for a team that might implement it or for future devs looking to implement this ADR

@bderusha bderusha linked a pull request Jun 26, 2023 that will close this issue
6 tasks
@github-actions
Copy link
Contributor

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

@github-actions github-actions bot added the stale label Sep 21, 2023
@bderusha
Copy link
Contributor Author

The PR for this is now ready for review @Willmish @vaughanknight

@github-actions github-actions bot removed the stale label Sep 22, 2023
Copy link
Contributor

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

@github-actions github-actions bot added the stale label Jan 21, 2024
@bderusha
Copy link
Contributor Author

@Willmish @vaughanknight bumping this. How can I help support this?

Copy link
Contributor

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

@github-actions github-actions bot added the stale label May 22, 2024
@bderusha
Copy link
Contributor Author

Still relevant. There is an open question about timing on the PR.

@danuw danuw added ADR and removed stale labels May 22, 2024
@danuw
Copy link
Collaborator

danuw commented May 22, 2024

Removed stale tag

@vaughanknight @Willmish can you help please ?

Copy link
Contributor

This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically.

@github-actions github-actions bot added the stale label Sep 20, 2024
@danuw
Copy link
Collaborator

danuw commented Sep 20, 2024

Hi @vaughanknight did you manage to talk about this in the end with @bderusha please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants