Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 8 support #164

Open
gilsdav opened this issue Jun 10, 2019 · 6 comments
Open

Angular 8 support #164

gilsdav opened this issue Jun 10, 2019 · 6 comments

Comments

@gilsdav
Copy link

gilsdav commented Jun 10, 2019

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if similar feature request does not exist
[ ] support request => Suggested place for help and support is [stackoverflow](https://stackoverflow.com/), search for similar question before posting

Description

Here is how I updated my fork : gilsdav/ngx-translate-router@ca881c2...master

Hope it will help

@kamilchlebek
Copy link

@gilsdav Unfortunately this solution is not going to work with AOT enabled. You're trying to inject compiler which is not available at runtime.

Is there any way to do it differently without accessing compiler?

@gilsdav
Copy link
Author

gilsdav commented Jul 9, 2019

@kamilchlebek ngx-translate-router is now compatible AOT and Universal on Angular 8 with the version 2.0.1

@kamilchlebek
Copy link

Thank you, I'll check it out

@mateobelanger
Copy link

Any updates on this?

@kamilchlebek
Copy link

Yes it's all good now. 2.0.1 works for AOT and JIT

@BruneXX
Copy link

BruneXX commented Sep 14, 2019

Hi Guys, can anyone give me an example that how should work this in node?
I've mean, the configuration for the browser.module it's fairly OK, but in the server side it seems not complete at all, I've reviewed a lot of outdated repos using this localize-route and others but it doesn't seem to work on compilation.
Please if anyone has a better example of how should work this in server side please share with me, so far the only thing that I've, (following all steps in the README.md from this repo) is an ERROR [Error] in (node) server side.
When I'm setting up the application in debug mode works like a charm but not in the same way after compilation process.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants