Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix length check for gzip. #14

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Fix length check for gzip. #14

merged 1 commit into from
Oct 8, 2023

Conversation

GunnarFarneback
Copy link
Owner

The gzip format ends with four bytes which should match the inflated size modulo 2^32. The modulo was missing so the range check would always fail for inflated size of 2^32 or more.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3c1119c) 99.35% compared to head (fec3b57) 99.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   99.35%   99.35%           
=======================================
  Files           1        1           
  Lines         468      468           
=======================================
  Hits          465      465           
  Misses          3        3           
Files Coverage Δ
src/Inflate.jl 99.35% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GunnarFarneback GunnarFarneback merged commit eaa54a3 into master Oct 8, 2023
14 checks passed
@GunnarFarneback GunnarFarneback deleted the gzip_length_check branch October 8, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants