Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mdl2obj Linux and macOS support #15

Closed
PeachIceTea opened this issue Feb 28, 2024 · 6 comments
Closed

mdl2obj Linux and macOS support #15

PeachIceTea opened this issue Feb 28, 2024 · 6 comments
Labels

Comments

@PeachIceTea
Copy link

Currently the code for mdl2obj is shipped as a Windows executable mdl2obj.exe.

I suppose it makes sense to not ask users on Windows to go install Node.js. For better support of Linux and macOS I would advocate to ship the raw Javascript and ask those users to simply install Node.

I would be happy to create a Pull Request with those changes if you think that is good enough of a solution.

As a side note the mdl2obj repo seems to be missing the source-mdl source code that is required to make it work.

@H2xDev
Copy link
Owner

H2xDev commented Feb 28, 2024

Hello! @PeachIceTea

As a side note the mdl2obj repo seems to be missing the source-mdl source code that is required to make it work.

Thank you for notice.
I updated dependencies and also added build instructions for macOS and Linux users, but didn't test it. Would be good if you test it.

@PeachIceTea
Copy link
Author

The new version does build and run under Linux. Can't test Mac right now, but I believe its safe to assume that pkg for Mac will work as well.

Personally I think I would prefer having source files and using my distros version of Node, but I understand the advantages of shipping something that will just work.

@Lachrymogenic
Copy link

Linux user here, Ubuntu 20.04.6 LTS x86_64.
mdl2obj compiles just fine, but doesn't run without source-mdl source code. Trying to make it work right now.

@PeachIceTea
Copy link
Author

@Lachrymogenic there is a new commit in the mdl2obj repo that fixes that issue. Just run npm i after pulling the newest commit and then npm run build:linux should work.

@H2xDev H2xDev added the macos label Feb 28, 2024
@Lachrymogenic
Copy link

Seems to be some sort of issue with your code, too. wouldnt run unless I converted
const [,, input, output] = process.argv; to var [,, input, output] = process.argv; due to an Assignment type error, where I believe output = output || input.replace('.mdl', '.obj'); was writing to a constant.

Seems to work completely fine after changing that one line now. Imports into blender just fine.

@H2xDev
Copy link
Owner

H2xDev commented Feb 28, 2024

Seems to work completely fine after changing that one line now. Imports into blender just fine.

I little bit rushed during fix, yes :D
Fixed.

@H2xDev H2xDev closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants