Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old delete icon for selected fields #27

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Remove old delete icon for selected fields #27

merged 1 commit into from
Dec 21, 2023

Conversation

eryanph
Copy link
Collaborator

@eryanph eryanph commented Dec 20, 2023

Issues addressed

  • NA

Changes description

  • Clicking trash icon on the side of a selected field causes error. Removed it since we have another way to delete fields now.
image

Due diligence

  • unit tests written in src/__tests__
  • passes all local unit tests
  • ran local mvn package successfully

Review/Merge

  • for review
  • for merge (removes branch after merge)

Stwissel
Stwissel approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@Stwissel Stwissel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stwissel Stwissel merged commit 9081ef8 into main Dec 21, 2023
4 checks passed
@Stwissel Stwissel deleted the ryan/dev branch December 21, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stwissel Stwissel Stwissel approved these changes

@ddsoriano26 ddsoriano26 Awaiting requested review from ddsoriano26

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eryanph @Stwissel