Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks to the codepaths related to the cross version IG pre-processor #928

Closed
wants to merge 4 commits into from

Conversation

brianpos
Copy link
Contributor

Specifically:

  • remove the hard-coded path to /Users/grahamegrieve/work/fhir-cross-version and pass the path via parameters
  • ensure the temp/xver-qa path exists before trying to read/write to it

@lmckenzi lmckenzi added bug Something isn't working Approved Change has been reviewed and accepted and can now be applied to the templates labels Jul 23, 2024
@grahamegrieve
Copy link
Contributor

I think we want to get rid of all those saving files that have hardcoded file paths

@brianpos
Copy link
Contributor Author

brianpos commented Jul 31, 2024

I think we want to get rid of all those saving files that have hardcoded file paths

@grahamegrieve I agree with that, but do need the other change here with the checking that the temp/xver-qa path exists...
(that's what's killing the package CI build at the moment)
Would you like a seperate PR with just that change in it?

@brianpos brianpos closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Change has been reviewed and accepted and can now be applied to the templates bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants