Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DfaRun extends CharSource but pushBack does not work #2

Open
HaraldKi opened this issue Feb 19, 2016 · 1 comment
Open

DfaRun extends CharSource but pushBack does not work #2

HaraldKi opened this issue Feb 19, 2016 · 1 comment

Comments

@HaraldKi
Copy link
Owner

Instead there are the unskip() methods. This is confusing.

Either get pushBack to work correctly or make sure it does not appear in the public interface.
@HaraldKi
Copy link
Owner Author

Not completely nonsensical. unskip() shoves back characters into the input of the DfaRun, while the inherited pushback() pushes character back into the output, i.e. the can be read() without being filtered.

Need at least a bit of documentation to remind the user of this detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HaraldKi