Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to dismiss Inline Suggestion #681

Open
RHJihan opened this issue Apr 12, 2024 · 6 comments · May be fixed by #675
Open

Option to dismiss Inline Suggestion #681

RHJihan opened this issue Apr 12, 2024 · 6 comments · May be fixed by #675
Labels
enhancement New feature or request

Comments

@RHJihan
Copy link
Contributor

RHJihan commented Apr 12, 2024

There should be an option to dismiss inline suggestion (an x button). Because, there are some cases where a user might expect suggestions instead of inline suggestion on a login field.

HeliBoard:
Screenshot_20240412_091232_Edge

Samsung Keyboard:
Screenshot_20240412_091924_Edge

@RHJihan RHJihan added the enhancement New feature or request label Apr 12, 2024
@RHJihan
Copy link
Contributor Author

RHJihan commented Apr 12, 2024

@codokie, I see you're working on inline suggestion, and I thought that the dismissal option might be helpful. Would you mind taking a look at it?

@codokie
Copy link
Contributor

codokie commented Apr 12, 2024

Which app show inline suggestions where regular suggestions are needed ? Is it the Github app?
Even if I add a dismiss button, depending on the input type of the app text editor, you might need to enable "Always show suggestions" for the regular suggestions to appear

@RHJihan
Copy link
Contributor Author

RHJihan commented Apr 12, 2024

It's GitHub website on Microsoft Edge.
I am saying if a user want to type login credentials with regular suggestions, they might want to dismiss the inline suggestion. Here inline suggestion is showing because it's a login page.

Here is the example for my case: I have saved some of my emails to the Personal Dictionary. So, sometimes I need to input email from the regular suggestions to log in. But here inline suggestion is showing with no way to dismiss it.

@codokie
Copy link
Contributor

codokie commented Apr 12, 2024

An easy solution would be to replace the icon and function of the expand toolbar key whenever the inline suggestions are visible.
I'll attempt to add this enhancement but it most likely depends on the changes made in the not yet approved PR #675

@codokie
Copy link
Contributor

codokie commented Apr 12, 2024

Btw, have you noticed the flickering of the inline suggestions too?
My password managers seem to spam inline suggestions requests

@RHJihan
Copy link
Contributor Author

RHJihan commented Apr 12, 2024

Btw, have you noticed the flickering of the inline suggestions too?

I use Keepass2Android. Never experienced the flickering issue you mentioned.

@codokie codokie linked a pull request Apr 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants