Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indication that file compression was reverted #245

Open
ARAKHN1D opened this issue Sep 22, 2024 · 6 comments · May be fixed by #254
Open

Indication that file compression was reverted #245

ARAKHN1D opened this issue Sep 22, 2024 · 6 comments · May be fixed by #254
Labels
feature-request Feature request

Comments

@ARAKHN1D
Copy link

ARAKHN1D commented Sep 22, 2024

Follow-up to #229. Maybe this could be a toast? Another thing to consider is, should this happen only when Curtail manually reverts the file, or also when the compressors skip the compression? The latter might be harder to figure out.

@Huluti
Copy link
Owner

Huluti commented Sep 27, 2024

I thought that maybe we could add the indication on each row? Instead of the percentage of reduction.
Maybe we could remove all the params that skip image if larger than original and rely on the system you added for all compressors?

@ARAKHN1D
Copy link
Author

The indicator on each row is a better idea. Removing the skipping params would make implementing this easier, so maybe that's what we should do. What should the indicator be? Text that just says "Skipped" or "Reverted"?

@Huluti
Copy link
Owner

Huluti commented Sep 28, 2024

Or maybe instead of removing the skipping params, we could just check the old size against the new size and if new size is equal or superior we could write this text. "Skipped" is perfect for me.
What do you think?

@ARAKHN1D
Copy link
Author

Checking the size would probably be better. I also think "Skipped" is a good indicator, but this is technically incorrect for the system when Curtail is in overwrite mode. Since it overwrites the file first, that's technically reverting the file. Maybe the system could be updated to compress the temp file first, check if that's bigger or smaller, and then copy that file onto the original if it's smaller. This would allow for skipping the file in overwrite mode, but it would also mean successful compression would have one additional step. Would that be okay with you?

@Huluti
Copy link
Owner

Huluti commented Oct 2, 2024

It seems like a good idea for me! If you want to work on it and if you want some help let me know :)

@ARAKHN1D
Copy link
Author

ARAKHN1D commented Oct 2, 2024

I'll work on it when I get the chance, and I'll ask you if I need help. Thanks :)

@Huluti Huluti added feature New feature feature-request Feature request and removed feature New feature labels Oct 13, 2024
ARAKHN1D pushed a commit to ARAKHN1D/Curtail that referenced this issue Oct 13, 2024
If compression was skipped for a file, the file's row will communicate
that it was. There will also be a more information button that will
explain why the file was skipped.

Closes Huluti#245
ARAKHN1D pushed a commit to ARAKHN1D/Curtail that referenced this issue Oct 13, 2024
If compression was skipped for a file, the file's row will communicate
that it was. There will also be a more information button that will
explain why the file was skipped.

Closes Huluti#245
@ARAKHN1D ARAKHN1D linked a pull request Oct 13, 2024 that will close this issue
Huluti pushed a commit to ARAKHN1D/Curtail that referenced this issue Oct 26, 2024
If compression was skipped for a file, the file's row will communicate
that it was. There will also be a more information button that will
explain why the file was skipped.

Closes Huluti#245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants