Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tape as dependency coverage #340

Open
davidkhala opened this issue Dec 22, 2023 · 3 comments
Open

tape as dependency coverage #340

davidkhala opened this issue Dec 22, 2023 · 3 comments

Comments

@davidkhala
Copy link
Member

Is your proposal related to a problem?

tape was used as a dependency in a second developement in other projects.
It worked before, but not again on 0.2.6

Describe the solution you'd like

create a another test that

  • having another go.mod file. It requires github.com/hyperledger-twgc/tape as dependency.
  • write a dummy go file simply import tape. if tape is isolated by sub package in different go module, also consider cover them as much as possible.
  • make this test covered in a new github workflow job

Describe alternatives you've considered

fix issue case by case, once we witnessed problem in other project. (reported based action)

https://github.com/davidkhala/fabric-tests/actions/runs/7295027060/job/19880816699#step:3:128

@SamYuan1990
Copy link
Member

hi @davidkhala
please ref this open-telemetry/opentelemetry-go#4586
personally, in recently as benefits from otel, I would like to make tape support otel in the feature if I am available.

@SamYuan1990
Copy link
Member

btw, could you please try https://github.com/Hyperledger-TWGC/tape/tree/v0.2.7

@davidkhala davidkhala changed the title tape as dependency: go.opentelemetry.io/otel/exporters/otlp issue tape as dependency coverage Dec 23, 2023
@davidkhala
Copy link
Member Author

tape@v0.2.7 works to elimaite above mentioned error. So can we extend this issue to a code coverage topic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants