Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify indexing conventions and fix offset errors #403

Open
faberno opened this issue Nov 19, 2024 · 0 comments
Open

Unify indexing conventions and fix offset errors #403

faberno opened this issue Nov 19, 2024 · 0 comments
Labels
bug Something isn't working feature New feature or request

Comments

@faberno
Copy link
Collaborator

faberno commented Nov 19, 2024

Please describe your 🚀 feature request.
SIMPAs indexing convention is messy:

  • MCX starts in the middle of voxels
  • kwave starts add beginning of a voxel, but we need to add +1 for matlab indexing

This behaviour and previous attempts to fix bugs introduced mulitple -1 and +1 across the code base, which are hard to understand and introduce more bugs.

@faberno faberno added bug Something isn't working feature New feature or request labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant