Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails #176

Open
jakobhaervig opened this issue Dec 9, 2024 · 3 comments
Open

Installation fails #176

jakobhaervig opened this issue Dec 9, 2024 · 3 comments

Comments

@jakobhaervig
Copy link

I'm following instructions found here https://imperialcollegelondon.github.io/PyProBE/user_guide/installation.html
All seems to install just fine but when I try to load the module with

import pyprobe

I get:
[WARNING] citations.read_citations(76): Citations could not be read because the 'pybtex' library is not installed. Install 'pybamm[cite]' to enable citation reading.

Also, my I suggest that all dependencies are kept in pyproject.toml only. The requirements.txt seems redundant to me?

@tomjholland
Copy link
Collaborator

Thanks @jakobhaervig, that user warning is from PyBaMM (a dependency). It causes no runtime issues but I will try to supress it.

@tomjholland
Copy link
Collaborator

Regarding requirements.txt, this is auto-generated from the pyproject.toml using pip-tools which ensures that the dependencies are compatible. This way they are not independent of each other. Having it in the repo removes the pip-compile step in the installation.

@jakobhaervig
Copy link
Author

Step 3 and the requirements.txt is redundant. You may have to specify versions in pyproject.toml directly. You can basically leave it out (step 3) and simply do pip install ., which will read dependencies from pyproject.toml. Only having dependencies listed one place is cleaner in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants