Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable switching of outfall detection method #203

Open
Tracked by #227
barneydobson opened this issue Jun 5, 2024 · 0 comments
Open
Tracked by #227

Enable switching of outfall detection method #203

barneydobson opened this issue Jun 5, 2024 · 0 comments
Labels
feature Adding a new functionality, small or large

Comments

@barneydobson
Copy link
Collaborator

Right, what you have here can be an option that users can activate if they really need multiple possible outfall locations with the caveat that it only considers proximity to water bodies. Having said that, I think adding more complexity to this outfall detection can be a low priority for the paper, since I think we already have enough material that we don't need to focus on this part, and we can leave it as a future direction.

Originally posted by @cheginit in #144 (comment)

Current method uses a mix of OSM rivers and lowest elevation point. Conceptually it may be more sound to just use lowest elevation point. Or certainly a user may want to choose.

This would be straightfoward to add a parameterised switch for.

@barneydobson barneydobson added the feature Adding a new functionality, small or large label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding a new functionality, small or large
Projects
None yet
Development

No branches or pull requests

1 participant