Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated polynomial solution for Yukawa #104

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

SonglanNie
Copy link
Contributor

@SonglanNie SonglanNie commented Oct 16, 2024

This adds the function polynomial_solution for the Yukawa PDE so that the vdim correction can be used for the volume potential with a Yukawa kernel. In addition, a typo in cavity2d_scattering.jl is fixed.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.85%. Comparing base (b256a92) to head (01c667a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/vdim.jl 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b256a92) and HEAD (01c667a). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b256a92) HEAD (01c667a)
4 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #104       +/-   ##
===========================================
- Coverage   79.89%   65.85%   -14.05%     
===========================================
  Files          24       24               
  Lines        3024     3022        -2     
===========================================
- Hits         2416     1990      -426     
- Misses        608     1032      +424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tanderson92
Copy link
Member

I will merge this PR, but note that future PRs should be checked with using JuliaFormatter and format(".") to ensure the formatting is done properly. That is why the check failed. If you forget (as I often do) and the checks fail (as they did here), you can still run those commands and upload a new commit to fix it.

@tanderson92 tanderson92 merged commit 4e6a348 into IntegralEquations:main Oct 19, 2024
3 of 5 checks passed
@maltezfaria
Copy link
Member

I will merge this PR, but note that future PRs should be checked with using JuliaFormatter and format(".") to ensure the formatting is done properly. That is why the check failed. If you forget (as I often do) and the checks fail (as they did here), you can still run those commands and upload a new commit to fix it.

For what is worth, I set my IDE (VSCode) to format on save so that I don't run into those issues any more. It is also easier on my eyes if the code is formatted as I write it 🙄

@SonglanNie SonglanNie deleted the yukawa branch October 20, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants