Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference shapes #2

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Reference shapes #2

merged 6 commits into from
Oct 2, 2023

Conversation

maltezfaria
Copy link
Member

@maltezfaria maltezfaria commented Sep 29, 2023

Implements some reference shapes to be used later for both interpolation and integration. Together with a push-forward map, this will later be used to interpolate and integrate over arbitrary elements.

Left to do:

  • Combine ReferenceTriangle and ReferenceTetra into a ReferenceSimplex{N}, similar to what is currently done for ReferenceHyperCube
  • Improve coverage with more testing

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bad3773) 0.00% compared to head (9e3e08c) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           main        #2        +/-   ##
===========================================
+ Coverage      0   100.00%   +100.00%     
===========================================
  Files         0         3         +3     
  Lines         0        19        +19     
===========================================
+ Hits          0        19        +19     
Files Coverage Δ
src/Geometry/referenceshapes.jl 100.00% <100.00%> (ø)
src/Inti.jl 100.00% <ø> (ø)
src/utils.jl 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maltezfaria
Copy link
Member Author

Is ready for a review? Thanks for the improvements.

@maltezfaria
Copy link
Member Author

Also, I think we should drop support for 1.6 (not worth it, specially as things start to become more complex).

Copy link
Member Author

@maltezfaria maltezfaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. I can handle them tomorrow, just wanted to point out what might change.

src/Geometry/referenceshapes.jl Outdated Show resolved Hide resolved
test/Geometry/referenceshapes_test.jl Show resolved Hide resolved
test/Geometry/referenceshapes_test.jl Show resolved Hide resolved
@maltezfaria maltezfaria marked this pull request as ready for review October 2, 2023 09:26
@maltezfaria maltezfaria merged commit 22fd8e0 into main Oct 2, 2023
5 checks passed
@tanderson92
Copy link
Member

@maltezfaria I don't understand what you mean by how the vertex test constructors are ``too verbose'' -- if there is a more efficient way to test the expected output of vertices I'm all for it, but I didn't know how.

@maltezfaria
Copy link
Member Author

@maltezfaria I don't understand what you mean by how the vertex test constructors are ``too verbose'' -- if there is a more efficient way to test the expected output of vertices I'm all for it, but I didn't know how.

I meant that

SVector{3, SVector{2, Int64}}([0, 0], [1, 0], [0, 1])

can be replaced by

SVector([0, 0], [1, 0], [0, 1])

and the tests will still pass.

@maltezfaria maltezfaria deleted the reference_shapes branch October 17, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants