Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference interpolation and integration #3

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

maltezfaria
Copy link
Member

@maltezfaria maltezfaria commented Oct 2, 2023

Implement the basic functionality needed to integrate and interpolate over an AbstractReferenceShape.

Things we may want to cover:

  • Hard-coded low-degree Lagrange interpolation
  • Some regular quadrature rules
  • A generic implementation of $P_k$ elements

@maltezfaria
Copy link
Member Author

I also decided to flatten the package structure a bit. Up for discussion.

@maltezfaria maltezfaria force-pushed the reference-interpolation-and-integration branch from c3e28a8 to 8f32174 Compare October 2, 2023 12:33
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 90 lines in your changes are missing coverage. Please review.

Comparison is base (22fd8e0) 100.00% compared to head (d715c49) 54.77%.

Additional details and impacted files
@@             Coverage Diff              @@
##              main       #3       +/-   ##
============================================
- Coverage   100.00%   54.77%   -45.23%     
============================================
  Files            2        5        +3     
  Lines           17      199      +182     
============================================
+ Hits            17      109       +92     
- Misses           0       90       +90     
Files Coverage Δ
src/Inti.jl 100.00% <ø> (ø)
src/reference_shapes.jl 100.00% <100.00%> (ø)
src/utils.jl 100.00% <100.00%> (ø)
src/reference_integration.jl 69.56% <69.56%> (ø)
src/reference_interpolation.jl 24.39% <24.39%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maltezfaria maltezfaria marked this pull request as ready for review October 2, 2023 15:31
Copy link
Member

@tanderson92 tanderson92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments.

@maltezfaria Would you like me to bring in Vioreanu-Rokhlin quadratures (for now, interpolation later perhaps) for tris/tets into this branch?

src/reference_integration.jl Show resolved Hide resolved
src/reference_interpolation.jl Show resolved Hide resolved
@maltezfaria
Copy link
Member Author

I left a few comments.

@maltezfaria Would you like me to bring in Vioreanu-Rokhlin quadratures (for now, interpolation later perhaps) for tris/tets into this branch?

I think we should, but I suggest we move forward with the domain/mesh part, then with integral operators, so that we get the ball rolling. But yes, that is definitely something we should keep on the radar for the near future. Maybe open an issue?

@tanderson92
Copy link
Member

I left a few comments.
@maltezfaria Would you like me to bring in Vioreanu-Rokhlin quadratures (for now, interpolation later perhaps) for tris/tets into this branch?

I think we should, but I suggest we move forward with the domain/mesh part, then with integral operators, so that we get the ball rolling. But yes, that is definitely something we should keep on the radar for the near future. Maybe open an issue?

Yes, looks good to me.

@maltezfaria maltezfaria merged commit afb413b into main Oct 4, 2023
3 of 5 checks passed
@maltezfaria maltezfaria deleted the reference-interpolation-and-integration branch October 17, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants