Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add equality checks to all "Region" implementations #2982

Open
NonSwag opened this issue Nov 9, 2024 · 1 comment
Open

Add equality checks to all "Region" implementations #2982

NonSwag opened this issue Nov 9, 2024 · 1 comment
Labels
Enhancement New feature or request upstream This PR pulls in upstream changes

Comments

@NonSwag
Copy link
Contributor

NonSwag commented Nov 9, 2024 •
edited
Loading

What feature do you want to see added?

Proper equals and hashCode methods for comparison of regions

Are there any alternatives?

Doing all checks yourself

Anything else?

Implementations of some collections and maps and basically everything in java that relies on comparison can't really work with regions because they have no equals or hashCode methods
@NonSwag NonSwag added the Enhancement New feature or request label Nov 9, 2024
@dordsor21 dordsor21 added the upstream This PR pulls in upstream changes label Dec 5, 2024
@NonSwag
Copy link
Contributor Author

NonSwag commented Dec 8, 2024

created issue upstream EngineHub/WorldEdit#2673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request upstream This PR pulls in upstream changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dordsor21 @NonSwag