Inconsistent SSLError Handling

[tucked]

The SDK claims support for urllib3 >= 1.15:

isilon_sdk_python/setup.py

Line 25 in 1995810

REQUIRES = ["urllib3 >= 1.15", "six >= 1.10", "certifi", "python-dateutil"]

In urllib3 1.22, MaxRetryError is raised instead of SSLError directly:

Made the connection pool retry on SSLError. The original SSLError is available on MaxRetryError.reason. (Issue #1112)

This means that if urllib3 >= 1.22 is used, this code is bypassed:

isilon_sdk_python/isi_sdk/rest.py

Lines 220 to 222 in 1995810

	except urllib3.exceptions.SSLError as e:
	msg = "{0}\n{1}".format(type(e).__name__, str(e))
	raise ApiException(status=0, reason=msg)

1. That means urllib3.exceptions.MaxRetryError is exposed directly to the caller (even though the use of urllib3 is an implementation detail).
2. The bypassed code discards the original exception which means that the caller must parse the ApiException.reason string to figure out what happened. In a way, this makes 1 preferable.

[tucked]

Also,

urllib3 does not have backward-compatibility guarantees on minor releases

So, pinning urllib3 to a compatible patch release (e.g. urllib3 ~= 1.15.1) is probably advisable.