Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont use Overwrite mixins #1558

Open
5 tasks done
MehVahdJukaar opened this issue Nov 16, 2024 · 1 comment
Open
5 tasks done

Dont use Overwrite mixins #1558

MehVahdJukaar opened this issue Nov 16, 2024 · 1 comment
Labels
Enhancement | 增强 New feature or request Version: Trials (1.20/1.20.1)

Comments

@MehVahdJukaar
Copy link

I have confirmed that ...

  • Arclight is up to date
  • all dependencies are installed
  • all plugins and mods are up to date
  • unable to reproduce in Spigot
  • unable to reproduce in Forge

Arclight version

1.20.1-1.0.6-SNAPSHOT

OS & Java versions

21

Plugins and Mods

no plugins

Description

The mod uses some @overwrite mixins.
These are fundamentally incompatible with other mods that might inject in those methods and should never be used.

An example is the creeper entity mixin

Step to reproduce

No response

Logs

No response

Server pack link (Optional)

No response
@MehVahdJukaar MehVahdJukaar added the Triage Default label, waiting for triage label Nov 16, 2024
@qyl27
Copy link
Collaborator

qyl27 commented Nov 16, 2024

Yes, we have now replaced @Overwrite with @Decorate in 1.20.4+.

@qyl27 qyl27 added Enhancement | 增强 New feature or request Version: Trials (1.20/1.20.1) and removed Triage Default label, waiting for triage labels Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement | 增强 New feature or request Version: Trials (1.20/1.20.1)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MehVahdJukaar @qyl27