Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Clang-Tidy #11

Open
JacksonAllan opened this issue May 29, 2024 · 0 comments
Open

Support for Clang-Tidy #11

JacksonAllan opened this issue May 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JacksonAllan
Copy link
Owner

In parallel with #10, it might be nice for Verstable to “support” Clang-Tidy by raising as few diagnostic warnings as possible.

Currently, Clang-Tidy is detecting many false positive NULL-dereferences regarding the buckets array pointer. This might be because it is not following the logic of the metadata “placeholder” mechanism and implicit guarantees it provides ensuring that buckets, when accessed, is not NULL.

These and other warnings could be silenced via liberal use of // NOLINT, although I am unsure about adding to the library any comments (or other content) whose purpose isn’t obvious. Such comments could perhaps be qualified with further comments explaining why they are necessary.

I’m opening this issue to keep a record and remind myself to investigate the matter further.

Relevant issues and pull requests:
#8
#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant