-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Minimize focused window option for launcher #769
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, this all looks great. I've raised a few minor points if you could have a look at those please.
I will be looking at merging this for 0.17, as soon as 0.16.1 is released.
Changes should be addressed now, thank you for taking a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, cheers. I'll give a quick test when I can & approve when confirmed working.
This PR adds a new config option
minimize_focused
to the launcher module, which when set to true will minimize the currently focused window if its icon is clicked. If there is more than a single window open of that particular application the normal focus behavior will occur.I haven't written much rust before, but hopefully it's relatively problem free!
Resolves #658