-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Favourite-Workspace that was focused during start of ironbar disappears when switching to a different workspace #705
Comments
JakeStanger
added a commit
that referenced
this issue
Oct 18, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay! Fixes #705 Also potentially fixes some other issues with workspaces.
JakeStanger
added a commit
that referenced
this issue
Oct 19, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay! Fixes #705 Fixes an issue with moving favourite workspaces. Fixes an issue with workspace visible state being incorrect. Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
JakeStanger
added a commit
that referenced
this issue
Oct 19, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay! Fixes #705 Fixes an issue with moving favourite workspaces. Fixes an issue with workspace visible state being incorrect. Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
JakeStanger
added a commit
that referenced
this issue
Oct 19, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay! Fixes #705 Fixes an issue with moving favourite workspaces. Fixes an issue with workspace visible state being incorrect. Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
JakeStanger
added a commit
that referenced
this issue
Oct 22, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay! Fixes #705 Fixes an issue with moving favourite workspaces. Fixes an issue with workspace visible state being incorrect. Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When adding favorites in the workspace module, the workspaces that were active when ironbar starts disappear when empty or emptied and I'm switching to a different workspace on that screen.
They stay hidden when trying to switch back.
To Reproduce
Steps to reproduce the behavior:
1.
=> ws-1 stays visible because something is open
=> workspace 1 disappears even though it is listed in favourites
=> workspace 1 stays hidden, even though it should not
Expected behavior
All workspaces listed in the favorites array should be visible in the bar at all times, even when empty.
System information:
Configuration
Config
issue persists even when using no stylesheet
Additional context
Screenshots
The text was updated successfully, but these errors were encountered: