Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favourite-Workspace that was focused during start of ironbar disappears when switching to a different workspace #705

Open
Lxtharia opened this issue Aug 13, 2024 · 0 comments · May be fixed by #748
Labels
bug Something isn't working
Milestone

Comments

@Lxtharia
Copy link

Describe the bug
When adding favorites in the workspace module, the workspaces that were active when ironbar starts disappear when empty or emptied and I'm switching to a different workspace on that screen.
They stay hidden when trying to switch back.

To Reproduce
Steps to reproduce the behavior:
1.

[[start]]
type = "workspaces"
favorites = [ "1", "2" ]
  1. switch to workspace 1
  2. Open something on ws-1
  3. start ironbar
    => ws-1 stays visible because something is open
  4. close whatever is on workspace 1
  5. switch to another workspace on that screen
    => workspace 1 disappears even though it is listed in favourites
  6. switch back to empty workspace 1 and open something
    => workspace 1 stays hidden, even though it should not

Expected behavior
All workspaces listed in the favorites array should be visible in the bar at all times, even when empty.

System information:

  • Distro: Arch Linux
  • Compositor: Sway
  • Ironbar version: 0.16.1-pre

Configuration

Share your bar configuration and stylesheet as applicable:

Config
position = "top"
height = 24

[[start]]
type = "workspaces"
# all_monitors = false
# favorites = { "DVI-D-1"=[ "1", "2", "3", "4" ] }
favorites = [ "1", "2" ]

center=[]

[[end]]
type = "tray"
direction = "right_to_left"

[[end]]
type = "music"
format = "{title}"

[[end]]
type = "clock"
format = "%d/%b/%Y | %H:%M:%S"

[[end]]
type = "notifications"
show_count = true

issue persists even when using no stylesheet

Additional context

Screenshots

@Lxtharia Lxtharia added the bug Something isn't working label Aug 13, 2024
@JakeStanger JakeStanger added this to the 0.16.1 milestone Aug 14, 2024
JakeStanger added a commit that referenced this issue Oct 18, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay!

Fixes #705

Also potentially fixes some other issues with workspaces.
@JakeStanger JakeStanger linked a pull request Oct 18, 2024 that will close this issue
JakeStanger added a commit that referenced this issue Oct 19, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay!

Fixes #705

Fixes an issue with moving favourite workspaces.

Fixes an issue with workspace visible state being incorrect.

Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
JakeStanger added a commit that referenced this issue Oct 19, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay!

Fixes #705

Fixes an issue with moving favourite workspaces.

Fixes an issue with workspace visible state being incorrect.

Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
JakeStanger added a commit that referenced this issue Oct 19, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay!

Fixes #705

Fixes an issue with moving favourite workspaces.

Fixes an issue with workspace visible state being incorrect.

Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
JakeStanger added a commit that referenced this issue Oct 22, 2024
Rewrites the module code to be better structured, in a similar pattern to the launcher. The code is now more robust and more maintainable, yay!

Fixes #705

Fixes an issue with moving favourite workspaces.

Fixes an issue with workspace visible state being incorrect.

Fixes an issue where the `inactive` class looked at hidden instead of closed favourites.
@JakeStanger JakeStanger modified the milestones: 0.16.1, 0.17.0 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants