New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove any .unwrap() and panic!s #3

Open

Jengamon opened this issue Oct 1, 2020 · 0 comments

Owner

Jengamon commented Oct 1, 2020 •

edited

Loading

For example:

ruwren/src/runtime.rs

Line 97 in eb68c25

    
           ffi::CString::new(string).unwrap_or_else(|_| panic!("Failed to convert source to C string for {}", module_name.to_string_lossy())).into_raw()

unwrapping or panicking in runtime.rs is UB as it crosses the C threshold. Remove these and replace with some kind of defaulting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment