-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JointsWP 6: Base Theme Style Discussion #368
Comments
Hi @JeremyEnglert! Thanks for all your hard work with JointsWP - it’s helped me out on a couple occasions and I’m excited to contribute to the new release. I share the same sentiment as you when it comes to a user deciding against using a framework; if a user decides to work without a framework the theme they receive should be completely stripped of all styling. This will allow developers to build out the front-end however they’d prefer. It also leaves the door open for developers (at agencies) to hook up their internal front-end stack/solution with the theme without having to worry about removing or editing files that are already in place. This also applies to including a CSS reset as part of the base styles. If a user is going to fully customize the way the front-end is built out, why not give them the ability to decide on their reset as well? It's pretty easy to include a CSS reset, and some developers might have their own custom solutions that they'd like to use. That’s all I have for now! 😁 |
Thanks for the feedback! I really appreciate it! I took the CSS reset out of the development branch. :) |
Here's some information about default styles for Gutenberg. |
Reveal Modals do not work on JointsWP 6. This is a fresh install with no active plugins. |
As already discussed, JointsWP 6 will allow users to install whatever framework they chose or select to work without a framework. If a user decides to work without a framework, we need to decide what the "base theme" should include (in regards to styles).
Some things we need to think about:
The text was updated successfully, but these errors were encountered: