Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JointsWP 6: Base Theme Style Discussion #368

Open
JeremyEnglert opened this issue Oct 15, 2018 · 4 comments
Open

JointsWP 6: Base Theme Style Discussion #368

JeremyEnglert opened this issue Oct 15, 2018 · 4 comments

Comments

@JeremyEnglert
Copy link
Owner

As already discussed, JointsWP 6 will allow users to install whatever framework they chose or select to work without a framework. If a user decides to work without a framework, we need to decide what the "base theme" should include (in regards to styles).

Some things we need to think about:

  • Should we include some type of menu system? This is often something users struggle with, so having a starting point is nice. But at the same time, menu systems are becoming pretty unique across sites - so a "starter" menu might just get in the way.
  • Do we want to include any styles at all? Some themes such as Bones (fun fact: JointsWP started as a fork of Bones) include basic styles. While others, such as Underscores, include almost no styles at all. I learn towards having no styles.
  • Do we want to include a CSS reset as part of the base styles? If so, which one?
@jspellman814
Copy link

Hi @JeremyEnglert!

Thanks for all your hard work with JointsWP - it’s helped me out on a couple occasions and I’m excited to contribute to the new release.

I share the same sentiment as you when it comes to a user deciding against using a framework; if a user decides to work without a framework the theme they receive should be completely stripped of all styling. This will allow developers to build out the front-end however they’d prefer. It also leaves the door open for developers (at agencies) to hook up their internal front-end stack/solution with the theme without having to worry about removing or editing files that are already in place.

This also applies to including a CSS reset as part of the base styles. If a user is going to fully customize the way the front-end is built out, why not give them the ability to decide on their reset as well? It's pretty easy to include a CSS reset, and some developers might have their own custom solutions that they'd like to use.

That’s all I have for now! 😁

@JeremyEnglert
Copy link
Owner Author

Thanks for the feedback! I really appreciate it!

I took the CSS reset out of the development branch. :)

@garretthyder
Copy link
Collaborator

@andytc
Copy link

andytc commented Jan 31, 2019

Reveal Modals do not work on JointsWP 6. This is a fresh install with no active plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants