Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap script should be idempotent #49

Open
gortok opened this issue Aug 11, 2015 · 0 comments
Open

Bootstrap script should be idempotent #49

gortok opened this issue Aug 11, 2015 · 0 comments

Comments

@gortok
Copy link
Contributor

gortok commented Aug 11, 2015

The Bootstrap script (bootstrap.sh) should be able to be run multiple times without adverse side effects. As pointed out in the README.md in #46, running it twice results in multiple KVPs being insert into the same keys/mc.json file.

Here's the offending lines:

touch keys/mc.json
echo -e "{\n\t\"apiKey\":\"\"\n}" >> ./keys/mc.json

Proposed fix would be to add an if block around the echo and ensure that file is empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant