Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Fix Ledger and Trezor Hardware support #286

Open
chmanie opened this issue Feb 13, 2020 · 0 comments
Open

Fix Ledger and Trezor Hardware support #286

chmanie opened this issue Feb 13, 2020 · 0 comments
Labels
help-wanted Extra attention is needed

Comments

@chmanie
Copy link
Member

chmanie commented Feb 13, 2020

Payout

Heads up! There's a bounty on this task! Go to https://colony.io/colony/beta/task/5e4565e3cbb233006996c39a learn more!

Description

Issue owner: raul@colony.io

The purser-ledger and purser-trezor packages do not work with current versions of the hardware. The goal is to fix support for both of these devices for message and transaction signing.

It should be possible to take the code from #271 and build on top of it.

This info from #271 might be helpful:

[...] such that the seeded signature values for the transaction to be signed (i.e. r, s and v) are not included. This is because ethereumjs-tx makes validations for EIP-155 that read these values (if present) and compare them with the chain ID, which was leading to validation errors for mainnet transactions.

This issue is regarded complete when:

  • Transaction signing (via purser's sign method) and arbitrary data signing (via purser's signMessag method) work on Trezor and Ledger devices with the latest firmware.
  • A test file is provided to be able to easily test this in a browser
  • A video is provided showing the login process working with a Ledger and a Trezor device
@chmanie chmanie added the help-wanted Extra attention is needed label Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants