Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Move this project to TypeScript #287

Open
chmanie opened this issue Feb 13, 2020 · 4 comments
Open

Move this project to TypeScript #287

chmanie opened this issue Feb 13, 2020 · 4 comments
Assignees
Labels
good-first-issue help-wanted Extra attention is needed

Comments

@chmanie
Copy link
Member

chmanie commented Feb 13, 2020

Payout

Heads up! There's a bounty on this task! Go to https://colony.io/colony/beta/task/5e4566a3cbb233006996c3a7 learn more!

Description

Issue owner: chris@colony.io

To be in line with our other projects in Colony, this library should be move to TypeScript.

These should be the minimal configs setting the "strictness" of the TS compiler (compilerOptions). Relaxation of these rules could be allowed if necessary (please consult the issue owner before making those changes).

    "lib": ["es2018"],
    "module": "commonjs",
    "moduleResolution": "node",
    "strictNullChecks": true,
    "strictPropertyInitialization": true,
    "target": "es6",

This issue is regarded done when:

  • All the code of all modules (purser-core, purser-software, purser-metamask, purser-ledger, purser-trezor) was converted to TypeScript and the test suite passes
  • The tooling was adjusted so that we can still easily build the project
  • The library was manually tested using purser-software (and a video is provided).

Bonus points: (the infamous 🌮- bonus):

Add the noExplicitAny compiler option and adhere to it. This might involve stubbing out types for the external libraries that we're using.

@chmanie chmanie added help-wanted Extra attention is needed good-first-issue labels Feb 13, 2020
@SurfingNerd
Copy link
Contributor

Hello, i am interested in doing this :), i could start in about 1-2 weeks. (around february 25th).
could you clarify if a trezor and ledger is needed for doing the tests ?

@chmanie
Copy link
Member Author

chmanie commented Feb 14, 2020

Hey @SurfingNerd! Sure, feel free to start on this any time! I'll assign you to this issue here in github. Can you request to work on it in Colony is well, so you'll get the bounty once you're done? What's your Colony username?

A Trezor or a Ledger is not needed to run the current test suite.

@befitsandpiper
Copy link

befitsandpiper commented Jun 26, 2020

Hi, is this task still open? I'm seeing messages of people saying it's done on BetaColony, and it's assigned to SurfingNerd here, but also all the updates seem super old.

@chmanie
Copy link
Member Author

chmanie commented Jun 29, 2020

@befitsandpiper we are still missing the ledger and trezor plugins in the typescript branch. You can follow the progress here: #322
If you feel like you want to contribute to this task, feel free to get in touch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good-first-issue help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants