Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript Support #3

Open
d0mmi opened this issue Nov 29, 2021 · 4 comments
Open

Typescript Support #3

d0mmi opened this issue Nov 29, 2021 · 4 comments
Labels
enhancement New feature or request resolved feature/bug is implemented/fixed, waiting for feedback

Comments

@d0mmi
Copy link

d0mmi commented Nov 29, 2021

Would it be possible for you to add TypeScript type definitions?

@JonnyC0G
Copy link
Owner

I don't have much experience with typescript, but I'll consider it :)

@JonnyC0G
Copy link
Owner

@d0mmi the new published version 0.2.6 contains typescript definitions, although I still don't know what exactly is happening there.
As far as I tested there should no breaking changes in functionality, but unfortunately the files are now wrapped in the dist-folder.

@JonnyC0G JonnyC0G added enhancement New feature or request resolved feature/bug is implemented/fixed, waiting for feedback labels Dec 28, 2021
@d0mmi
Copy link
Author

d0mmi commented Dec 28, 2021

@d0mmi the new published version 0.2.6 contains typescript definitions, although I still don't know what exactly is happening there.
As far as I tested there should no breaking changes in functionality, but unfortunately the files are now wrapped in the dist-folder.

Screenshot_20211228-082440.jpg
That's why they are in the dist folder

@JonnyC0G
Copy link
Owner

yeah i know that. the module is coded in ts, but i wanted to publish just the compiled js files. and for obvious reasons i don't want my compiles sources in the project root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resolved feature/bug is implemented/fixed, waiting for feedback
Projects
None yet
Development

No branches or pull requests

2 participants