Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VS Code to handle files #3

Open
3 of 5 tasks
fonsp opened this issue Sep 23, 2021 · 2 comments · Fixed by #17
Open
3 of 5 tasks

Use VS Code to handle files #3

fonsp opened this issue Sep 23, 2021 · 2 comments · Fixed by #17
Assignees
Labels
Host Requires changes to the extension host Pluto.jl backend Requires integration with/changes to Pluto's backend (Julia) codebase Pluto.jl frontend Requires integration with/changes to Pluto's frontend (JS) codebase
Milestone

Comments

@fonsp
Copy link
Contributor

fonsp commented Sep 23, 2021

Instead of Pluto's file manager. This means:

  • No more file UI at the top of Pluto
  • Knowing when VS Code renames/moves a file and update Pluto to match. This means that users will use the existing VS Code API to rename/move/delete files, which is very cool!
  • Knowing when VS Code deletes a file and update Pluto to match. This means that users will use the existing VS Code API to rename/move/delete files, which is very cool!
  • Maybe register a command / add a button to rename the notebook file?
  • Turn on file watching in Pluto by default
@fonsp fonsp added this to the IDE milestone Nov 3, 2021
@fonsp fonsp added Host Requires changes to the extension host Pluto.jl frontend Requires integration with/changes to Pluto's frontend (JS) codebase Pluto.jl backend Requires integration with/changes to Pluto's backend (Julia) codebase labels Nov 3, 2021
@pankgeorg pankgeorg self-assigned this Nov 8, 2021
@fonsp
Copy link
Contributor Author

fonsp commented Nov 9, 2021

@pankgeorg @pankgeorg @pankgeorg yay

@pankgeorg
Copy link
Member

pankgeorg commented Nov 15, 2021

@fonsp renaming of files and stuff works like a charm. Pluto doesn't (at this point and against @pfitzseb advice) watch the same file as VSCode does. Pluto has a temp file and comminicates with the VSCode extension for updates. BetterFileWatching is not enabled for this, on the VSCode -> Pluto side, we send an update command and run update_from_file via STDIN and for the Pluto -> VSCode side we type pirate 🦜 the save function of Pluto to also send an update command via STDOUT, only if the file (the result of the save_notebook function) changed.

@fonsp fonsp linked a pull request Nov 19, 2021 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Host Requires changes to the extension host Pluto.jl backend Requires integration with/changes to Pluto's backend (Julia) codebase Pluto.jl frontend Requires integration with/changes to Pluto's frontend (JS) codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants