Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other KNN Algorithms #38

Open
JonasIsensee opened this issue Sep 20, 2018 · 1 comment
Open

Other KNN Algorithms #38

JonasIsensee opened this issue Sep 20, 2018 · 1 comment
Assignees
Labels
big project Significant work from both coding and scientific perspective decision Decide how to proceed with this enhancement New feature or request optional Not really crucial, and also not very important. wanted feature We want this!

Comments

@JonasIsensee
Copy link
Member

JonasIsensee commented Sep 20, 2018

In most cases more than 90% of runtime is spent within the knn algorithm.

Therefore it may be worth looking into other knn implementations.

Here is a list with various algorithms with python interfaces.
http://ann-benchmarks.com/
https://github.com/erikbern/ann-benchmarks

In particular this one
https://github.com/nmslib/hnsw
might be of interest.

We will likely need a Julia wrapper which should be it's on package.
Maybe somehow connected to NearestNeighbors.jl ?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@JonasIsensee JonasIsensee added enhancement New feature or request wanted feature We want this! big project Significant work from both coding and scientific perspective decision Decide how to proceed with this optional Not really crucial, and also not very important. labels Sep 20, 2018
@Datseris
Copy link
Member

Datseris commented Sep 21, 2018

This is discussed in parallel here: KristofferC/NearestNeighbors.jl#69 and KristofferC/NearestNeighbors.jl#73

But I wouldn't immediatelly agree with the comment to have them at the package NearestNeighbors.jl . Depends on what is done, and if its simply a wrapper or not, and how much of the NN.jl interface it shares.

@JonasIsensee JonasIsensee self-assigned this Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big project Significant work from both coding and scientific perspective decision Decide how to proceed with this enhancement New feature or request optional Not really crucial, and also not very important. wanted feature We want this!
Projects
None yet
Development

No branches or pull requests

2 participants