New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency of source code for crossprediction #78

Open

Datseris opened this issue May 2, 2019 · 0 comments

Labels

Member

Datseris commented May 2, 2019 •

edited

Loading

The docstring of crossprediction, which btw we may want to rename to crossestimation has:

crossprediction(source_train, target_train, source_pred,

yet none of these terms are in the source code for the function , which reads:

function crossprediction(train_in ::AbstractVector{<:AbstractArray{T, Φ}},
                        train_out::AbstractVector{<:AbstractArray{T, Φ}},
pred_in ::AbstractVector{<:AbstractArray{T, Φ}},

or

function crossprediction(params, train_out,pred_in, R, tree; progress=true)

I think it is best if there is an agreement on the terms used and the same thing is used for documentation and source code.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

The text was updated successfully, but these errors were encountered:

Datseris added the documentation label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment