New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplication of inner to reduce source #81

Open

Datseris opened this issue May 15, 2019 · 0 comments

Assignees

Member

Datseris commented May 15, 2019 •

edited

Loading

The code in e.g. https://github.com/JuliaDynamics/TimeseriesPrediction.jl/blob/master/src/symmetric_embedding.jl#L128 is shared (because it is independent of the boundary conditions). It may be that this happens in other cases as well, besides symmetric embeddings.

We should make it a function and re-use it instead, to reduce total loc and improve clarity.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Datseris self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment