Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PkgExtensions #3

Open
MasonProtter opened this issue May 15, 2023 · 1 comment
Open

Migrate to PkgExtensions #3

MasonProtter opened this issue May 15, 2023 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MasonProtter
Copy link
Member

See JuliaFolds2/BangBang.jl#2 for an example of this and https://pkgdocs.julialang.org/v1/creating-packages/#Conditional-loading-of-code-in-packages-(Extensions) for the relevant documentation.

There's a number of conditionally loaded packages in Transducers.jl: https://github.com/JuliaFolds2/Transducers.jl/blob/master/src/Transducers.jl#L176-L196, and also some unconditionally loaded packages like Tables.jl that don't really need to be direct dependencies.

PRs migrating Transducers.jl to using the Extension system would be much appreciated.

@MasonProtter MasonProtter added good first issue Good for newcomers help wanted Extra attention is needed labels May 15, 2023
@simsurace
Copy link

Seems the first part of this was solved by #5. The second part is still open, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants